search

SpiralMoon / maplestory.openapi

🍁 MapleStory Open API Client Library for JavaScript, TypeScript, Java, C#, Python. 메이플스토리 OpenAPI 라이브러리입니다. 다양한 언어를 지원합니다. 🍁
https://openapi.nexon.com/game/maplestory
MIT License
26 stars 3 forks source link

(python) 변수 type 에 대한 몇 가지 오류 #40

Closed catahat closed 9 months ago

catahat commented 9 months ago

1. https://github.com/SpiralMoon/maplestory.openapi/blob/700a5eb62d660cbe70076aa6cc8eac3a7f03bd35/python/maplestory_openapi/api/dto/character/character_item_equipment.py#L309

CharacterItemEquipment.title can be null ("title": null)

title: CharacterItemEquipmentTitle | None 2. https://github.com/SpiralMoon/maplestory.openapi/blob/700a5eb62d660cbe70076aa6cc8eac3a7f03bd35/python/maplestory_openapi/api/dto/character/character_basic.py#L26

CharacterBasic.character_guild_name can be null ("character_guild_name": null) character_guild_name: str | None 3. https://github.com/SpiralMoon/maplestory.openapi/blob/700a5eb62d660cbe70076aa6cc8eac3a7f03bd35/python/maplestory_openapi/api/dto/character/character_item_equipment.py#L291

CharacterItemEquipmentTitle.date_option_expire can be "expired" ("date_option_expire": "expired") date_option_expire: datetime | None | str

SpiralMoon commented 9 months ago

solved https://github.com/SpiralMoon/maplestory.openapi/pull/41, https://github.com/SpiralMoon/maplestory.openapi/pull/42

SpiralMoon commented 9 months ago

released v2.3.2