Spirals-Team / docker-machine-driver-g5k

Docker Machine driver for the Grid'5000 testbed infrastructure.
https://www.grid5000.fr
Apache License 2.0
13 stars 5 forks source link

Cleanup, refactoring, add command line flags, changed imports, readme update #4

Closed gfieni closed 8 years ago

gfieni commented 8 years ago

PR overview:

zhangbbo commented 8 years ago

I tested on MacOS and Ubuntu 14.04, it works. But when I want to create docker node, always getting (Error: No machine name specified).

Then I add a name "test", always returning (Error setting machine configuration from flags provided: gob: name not registered for interface: "*rpcdriver.RpcFlags").

Docker Client: Version: 1.9.0 API version: 1.21 Go version: go1.4.3 Git commit: 76d6bc9 Built: Tue Nov 3 19:20:09 UTC 2015 OS/Arch: darwin/amd64

Docker-Machine Version: 0.5.0

mcolmant commented 8 years ago

@zhangbbo did you try to update your docker with the last release?

zhangbbo commented 8 years ago

Yeah, I tried. @mcolmant (Error setting machine configuration from flags provided: gob: name not registered for interface: "*rpcdriver.RpcFlags") refers to a bug in old docker-machine, and it has been fixed after 0.5.4

The code works well in MacOS and Ubuntu 14.04

docker version Client: Version: 1.12.0 API version: 1.24 Go version: go1.6.3 Git commit: 8eab29e Built: Thu Jul 28 23:54:00 2016 OS/Arch: darwin/amd64

Server: Version: 1.12.0 API version: 1.24 Go version: go1.6.3 Git commit: 8eab29e Built: Thu Jul 28 23:54:00 2016 OS/Arch: linux/amd64

docker-machine v0.8.0, build b85aac1