Closed soldetres closed 4 years ago
Hi Inti, There are a few things to clean up in the attero_100G projectbefore I can merge:
Response maps: some of these appear to be duplicates of the same command with slightly different options. Use the wildcard feature to make these cover multiple variations if possible. Name the files after the command they map, and remove extra underscores and stuff that iTest auto-adds. Also, at least one file looks like it doesn't have any queries in it. Maybe it should be deleted.
attero_100G_tcl_base.fftc appears to be a procedure library. Indicate that in the file name to avoid confusion with QC libs.
There is an empty session profile file in the root of the project called .1.ffsp. You may not even be able to see it in you iTest explorer window. Not sure what this is, but it should probably be removed.
The other project looks good.
Thank You Alex,
I will proceed with the edits and update back.
Inti
On Wed, Aug 5, 2020, 4:17 PM alexorr notifications@github.com wrote:
Hi Inti, There are a few things to clean up in the attero_100G projectbefore I can merge:
Response maps: some of these appear to be duplicates of the same command with slightly different options. Use the wildcard feature to make these cover multiple variations if possible. Name the files after the command they map, and remove extra underscores and stuff that iTest auto-adds. Also, at least one file looks like it doesn't have any queries in it. Maybe it should be deleted.
attero_100G_tcl_base.fftc appears to be a procedure library. Indicate that in the file name to avoid confusion with QC libs.
There is an empty session profile file in the root of the project called .1.ffsp. You may not even be able to see it in you iTest explorer window. Not sure what this is, but it should probably be removed.
The other project looks good.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Spirent/iTest-assets/pull/70#issuecomment-669479736, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLH7D4IAD4JDCEXQGINXLR7G45HANCNFSM4PL5U6QA .
Proposed Changes
Describe your changes here to communicate the purpose of the pull request.
Types of Changes
What types of changes does your code introduce? Added library for Attero-X. Added library for Attero-100G. Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask @cwhitty. We're here to help! This is simply a reminder of what we are going to look for before merging your code.[x] Project contains a file called documentation/readme.txt with metadata necessary for the catalog. The readme.txt file must contain these 4 lines at the top of the file:
Project: Name of project
Description: 80 or so characters describing the contents of the project
Category: ("library" | "automation" | "framework")
Class: ("Community" | "Tested by Spirent" | "Reference").
Other info like user instructions, a description of the intended use case, etc. can be added to the readme.txt after the 4 required lines.
Note: A README.md file will be automatically generated including everything in the readme.txt file and a list of files, QuickCalls, and procedures with info from iTest's documentation fields. Do not create a README.md file, it will be overwritten. For the best possible documentation, fill out the description fields in each test case, procedure and QuickCall.