Spirent / iTest-assets

Spirent iTest Automation Asset Warehouse
MIT License
7 stars 24 forks source link

Adding Attero-X/Attero-100G iTest libraries. #70

Closed soldetres closed 4 years ago

soldetres commented 4 years ago

Proposed Changes

Describe your changes here to communicate the purpose of the pull request.

Types of Changes

What types of changes does your code introduce? Added library for Attero-X. Added library for Attero-100G. Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask @cwhitty. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

alexorr commented 4 years ago

Hi Inti, There are a few things to clean up in the attero_100G projectbefore I can merge:

Response maps: some of these appear to be duplicates of the same command with slightly different options. Use the wildcard feature to make these cover multiple variations if possible. Name the files after the command they map, and remove extra underscores and stuff that iTest auto-adds. Also, at least one file looks like it doesn't have any queries in it. Maybe it should be deleted.

attero_100G_tcl_base.fftc appears to be a procedure library. Indicate that in the file name to avoid confusion with QC libs.

There is an empty session profile file in the root of the project called .1.ffsp. You may not even be able to see it in you iTest explorer window. Not sure what this is, but it should probably be removed.

The other project looks good.

soldetres commented 4 years ago

Thank You Alex,

I will proceed with the edits and update back.

Inti

On Wed, Aug 5, 2020, 4:17 PM alexorr notifications@github.com wrote:

Hi Inti, There are a few things to clean up in the attero_100G projectbefore I can merge:

Response maps: some of these appear to be duplicates of the same command with slightly different options. Use the wildcard feature to make these cover multiple variations if possible. Name the files after the command they map, and remove extra underscores and stuff that iTest auto-adds. Also, at least one file looks like it doesn't have any queries in it. Maybe it should be deleted.

attero_100G_tcl_base.fftc appears to be a procedure library. Indicate that in the file name to avoid confusion with QC libs.

There is an empty session profile file in the root of the project called .1.ffsp. You may not even be able to see it in you iTest explorer window. Not sure what this is, but it should probably be removed.

The other project looks good.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Spirent/iTest-assets/pull/70#issuecomment-669479736, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXLH7D4IAD4JDCEXQGINXLR7G45HANCNFSM4PL5U6QA .