Spirent / iTest-assets

Spirent iTest Automation Asset Warehouse
MIT License
7 stars 24 forks source link

Spirent Umetrix Video Library - Initial Version #78

Closed soldetres closed 3 years ago

soldetres commented 3 years ago

Proposed Changes

Spirent Umetrix Video Library Initial Release

Types of Changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask @cwhitty. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

alexorr commented 3 years ago

QCs: UploadVideo references a file on your local machine in the POST line, causing an error in other workspaces In GetLogs, please explain how the inTime arg works in more depth I'm assuming the purpose of methodologyId and sessionId throughout would be obvious to someone using the lib In IsChannelReady, the isReady argument doesn't appear to be used In proc lib: Need argument descriptions in CreateReport Don't reference params in procs or QCs like you are doing in the initialization scripts through the lib. Pass things in explicitly as args.