search

SpiritCroc / DefaultDarkTheme-oms

Android Substratum theme
Other
49 stars 16 forks source link

Notification Color #24

Open Rintan opened 6 years ago

Rintan commented 6 years ago

Some system notification color doesn't match the other notifications. Android 8.0.0 Substratum 992 Andromeda 22 Android 8 darker

SpiritCroc commented 6 years ago

I assume you are using a ROM without Substratum exposure commits (some more information about your operating system would be useful), since it should be fine on those that have them in. Unfortunately, there are some restrictions on what can be done when running such a ROM, so don't know right now whether a fix is actually possible. Don't have much time right now, so will keep this open for now

PandaFoss commented 4 years ago

I have a similar problem, some notifications are seen correctly but others are not (black letter on dark background). I am using an unofficial version of Lineage OS that supports Substratum (variant A obtained from here). What could be the problem?

SpiritCroc commented 4 years ago

I have a similar problem, some notifications are seen correctly but others are not (black letter on dark background). I am using an unofficial version of Lineage OS that supports Substratum (variant A obtained from here). What could be the problem?

The problem is again likely missing Substratum exposure commits. Since LineageOS 14.1 is rather old, it is possible that the required commits where not available at that point, and might need backporting from later Android versions.

Since you didn't tell what text exactly is broken, I can't tell for sure. In case you have the exact same issue as the text in the screenshots above, your ROM is probably missing this: https://gerrit.aicp-rom.com/c/AICP/frameworks_base/+/33532

A common issue with older Android versions is the fact that applications can actually decide on text colors themselves, thus overwriting the theme color. A workaround exists for that in Substratum exposure commits since Pie. Maybe your ROM maintainer can backport it, I haven't checked if it is applicable on older Android versions. The relevant commit is here: https://gerrit.aicp-rom.com/c/AICP/frameworks_base/+/77600