support spaces in command-line args

[neogeographica]

On modern Windows systems, any arg that is a path value is somewhat likely to have spaces in it.

Linux and SDL builds for Quake tend to handle these correctly, but various non-SDL Windows builds don't really. Let's fix it here!

The main change is in WinMain in sys_win.c, to make sure we interpret the argument tokens from the command line correctly. See the code comments for more details.

---

COM_InitArgv in common.c needs an ancillary change, to properly show arguments-with-spaces in the constructed "cmdline" console variable. From a user's POV this is muuuch less interesting than the main change, since the cmdline variable is just an informative thing (and rarely used I think). But getting it right is somewhat tricky.

The problem looks like this:

• We want to populate a var with the command line used to launch Quake.
• We are trying to reconstruct that command line from the argument vector.
• Proper reconstruction depends on the arg-quoting conventions in the environment used to launch Quake.

I settled on an approach that is not super-crossplatform-elegant but which has minimal churn to the existing code:

• COM_InitArgv will use a bash-like quoting convention for command-line reconstruction. Pretty simple stuff: quote arguments that contain whitespace, backslash-quote any actual quote chars, and backslash-quote backslash chars as needed.
• If the caller doesn't want that convention (which, in Windows, we don't) then the caller can provide the actual command line if that's available, to be used instead of reconstructing from the arg vector. On Windows, the command line is in fact available, so provide it.

---

I've been using this with the Windows build... works fine, populates the cmdline var as expected. Example screenshot here from a launch using a basedir path that contains spaces:

The Linux build compiles and starts, but I don't have a graphical Linux environment yet that can run reQuiem (it fails with XF86DGANoDirectVideoMode). So you'll probably want to sanity-test this on Linux still. Or wait until I can. :-) Maybe there's a way to get my CentOS VM (VMware Fusion) capable of running this.

[neogeographica]

I managed to run it in a Linux VM using the -nodga switch.

[neogeographica]

I notice that on the Linux side, it doesn't remove the executable name from the "cmdline" value. This is pre-existing behavior, not part of my change. Is there a reason for the difference there between the Windows and Linux behaviors?

I don't know if other Linux Quake engines behave the same way.

[neogeographica]

Yep QuakeSpasm shows the executable name/path in its "cmdline" value on Linux too. But not on Windows.

I guess this pull shouldn't change that behavior. It can be tackled in a different pull if it becomes a desired change.

There's some discussion of "cmdline" here: http://forums.inside3d.com/viewtopic.php?f=3&t=4546

... which kind of gets into why the exe might be hidden ("DON'T LOOK AT MY PATHS"), but the same argument would apply to the Linux side if so. Not to mention -basedir args etc. So I dunno.

[SpiritQuaddicted]

sorry that I forgot about these old pull requests, merging all the things now. this sounds like a nice fix, thanks!