Oakwood module compatibility issue in Out and Math

[rsdoiel]

Out.Real takes two parameters your implementation wraps Files.Real which only takes one.

Math.power() is missing.

Thank you for a nice open source Oberon-7 compiler, Robert Doiel

[Spivoxity]

I don't especially try to follow the Oakwood guidelines, but I see Out.Real takes a width parameter even in the Reiser/Wirth book. That's unfortunate and should perhaps be fixed even if it does break existing programs.

Math.power and MathL.power could easily be added, but I don't feel inclined to add all the other stuff from the Oakwood document, e.g., arcsinh.

[rsdoiel]

On 6/15/21 3:00 PM, Mike Spivey wrote:

I don't especially try to follow the Oakwood guidelines, but I see Out.Real takes a width parameter even in the Reiser/Wirth book. That's unfortunate and should perhaps be fixed even if it does break existing programs.

Math.power and MathL.power could easily be added, but I don't feel inclined to add all the other stuff from the Oakwood document, e.g., arcsinh.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Spivoxity/obc-3/issues/43#issuecomment-861864672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJIPK2YHJ6PW4ZZDCOWGDTS7EPHANCNFSM46T4LPDA.

I'm not good with Ocaml (never really coded anything aside toy examples) but I am OK with the C and Oberon-7.

Would you mind terribly if I gave it a shot at addressing the issue and then gave you a pull request? For me it is a hobby but since you're still teaching I understand if it doesn't meet with the needs of instruction.

All the best,

Robert

[Spivoxity]

Fixed in 83e6f2b19c38163752c72784759a0704096a260f

[Spivoxity]

Sorry to pre-empt your offer of help, Robert, but I made the changes this evening.