search

Spksh / TentacleSoftware.TeamSpeakQuery

A task-based event-driven Team Speak 3 ServerQuery client that supports SOCKS4 proxies.
http://www.tentaclesoftware.com
Other
7 stars 4 forks source link

Undocumented -ip option missing in Option enum #8

Closed ghost closed 9 years ago

ghost commented 9 years ago

The documentation doesn't mention the -ip option but it's used on the clientlist command to include client IP addresses.

It may be beneficial to include the ability to define additional options.

Spksh commented 9 years ago

Added -ip in 7dcf8a9dc9fe0c0e1db6d9828d5ef7d09bbbb99f, let me know if that works for you.

If you need arbitrary parameters and options, you can write extended versions of ResultFactory.ToCommandString and ServerQueryCommand. Wouldn't be too hard to add an arbitrary stringifier.

ghost commented 9 years ago

It should work, did the same in my fork. :)

Spksh commented 9 years ago

Cool. If you make another fix like this, definitely submit a pull request :)