(hopefully) no cloudlink usernames

Splash-Media-Co / server

Backend server for Splash

6 stars 0 forks source link

(hopefully) no cloudlink usernames #15

Closed EngineerRunner closed 7 months ago

EngineerRunner commented 7 months ago

currently, because Cloudlink™, you can just change your username after authenticating. this should fix it, unless my code is crap (like usual).

this PR just adds all usernames to a list, and these usernames should have the same index as the client ID, altho i havent tested this yet.

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

delusionsGH commented 7 months ago

please test when you have done so, please reply so i can merge

delusionsGH commented 7 months ago

please test when you have done so, please reply so i can merge

nevermind, fenix will review

EngineerRunner commented 7 months ago

ik but it uses the index of the client id in the authenticated clients list

On Thu, 8 Feb 2024, 17:05 notfenixio, @.***> wrote:

Actually client IDs are a set of numbers and letters, like a UUID

— Reply to this email directly, view it on GitHub https://github.com/Splash-Media-Co/server/pull/15#issuecomment-1934561049, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5QIPBTBHEMZJ5YAZ2ABJD3YSUAU3AVCNFSM6AAAAABDACNTAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGU3DCMBUHE . You are receiving this because you authored the thread.Message ID: @.***>

showierdata9978 commented 7 months ago

you can disable commands on cl