search

Splash-Media-Co / server

Backend server for Splash
6 stars 0 forks source link

image (and other attachments technically) support #7

Closed EngineerRunner closed 8 months ago

EngineerRunner commented 8 months ago

adds support for attachments, including images. we probably need a host whitelist tho since somebody might be able to achieve RCE with loading .js, idk here's a client example that allows for image viewing engineerrunner's splash client beta 6 WITH IMAGES.zip

NotFenixio commented 8 months ago

db.json does not automatically update the DB schema. Do you mind executing this and then commiting? python dber.py and

ALTER TABLE posts ADD COLUMN attachment TEXT
EngineerRunner commented 8 months ago

i thought i did, is it giving an error?

On Wed, 3 Jan 2024, 11:23 notfenixio, @.***> wrote:

db.json does not automatically update the DB schema. Do you mind executing this and then commiting? python dber.py and

ALTER TABLE posts ADD COLUMN attachment TEXT

— Reply to this email directly, view it on GitHub https://github.com/Splash-Media-Co/server/pull/7#issuecomment-1875214440, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5QIPBSL6V7D3T7YIV3GSJDYMU5RZAVCNFSM6AAAAABBLFXO2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGIYTINBUGA . You are receiving this because you authored the thread.Message ID: @.***>

NotFenixio commented 8 months ago

Oh nevermind just saw the file change, I didn't notice. LGTM.

EngineerRunner commented 8 months ago

aight i'll merge it now then