search

Splidejs / splide

Splide is a lightweight, flexible and accessible slider/carousel written in TypeScript. No dependencies, no Lighthouse errors.
https://splidejs.com
MIT License
4.89k stars 424 forks source link

Bug fix : instanceOf returns false #1273

Open redoC-A2k opened 9 months ago

redoC-A2k commented 9 months ago

Related Issues

fixes #1272

Description

I tried to debug the issue , while debuggging I found out that even though splide_list element containing HTMLElement in prototype chain the isHTMLElement was returning false . I compared the two window variables one was iframe and other should be global window , but in grapesjs case the two window variables were same and I think that's why instanceOf might be returning false . When I used window.top instead of window isntanceOf returns true as expected .

TobiasRoos-Dev commented 7 months ago

@NaotoshiFujita could you already review this pull request? I have a problem which this request would fix. I render for a cms splide in an iframe and this isn't possible for chrome browsers