search

Splinter0 / PyHero

PyHero is a software written in python that allows you to control your GoPro HERO, HERO2, HERO3 and HERO4 from a command line!
GNU General Public License v3.0
9 stars 1 forks source link

A few issues and improvements #2

Open KonradIT opened 7 years ago

KonradIT commented 7 years ago

Camera: GoPro HERO4 Black

Firmwate V: 5.00

Splinter0 commented 7 years ago

Thanks a lot! The scripts disconnects because there's a threading that checks whether the connection is still alive or not, but you're right sometimes it disconnects. I'll fix it

KonradIT commented 7 years ago

I fixed the password issue, as per the folder stuff, check how I've done it, I'll try to implement it into python.

Looks like HERO4 should either get manual password input or use gpControl commands.

Ok, now i'm working detect what kind of camera is connected. Send me your work please or pull it in the one you forked

Splinter0 commented 7 years ago

Check your email we'll text there ;) (I need to know what you've changed 'cause i was working on it now XD ) @KonradIT

Splinter0 commented 7 years ago

Ok, now i'm working detect what kind of camera is connected. Send me your work please or pull it in the one you forked

Splinter0 commented 7 years ago

The detect function works just fine, now i'' have to create some functions that changes the content of the commands

cya

Splinter0 commented 7 years ago

@KonradIT Hey man, can you please try out the onDev branch and see if it works with gopro hero4? by the way i just did on and off for gopro4

KonradIT commented 7 years ago

@Splinter0 it does not work, I also fixed a global var bug

Splinter0 commented 7 years ago

yeah i saw that on your repo.. thanks. ok i'm working on it @KonradIT

KonradIT commented 7 years ago

@Splinter0 sorry I did not specify, the python script attempts to connect to my camera (HERO4 Black) for around 3 seconds and then it shows error message. I am connected to the camera as you can see and even tested with my api gopro-rb-api and gopro-py-api. <== this libraries will support HERO3/3+ in the future!

Splinter0 commented 7 years ago

that is wierd... With the older version ( in the master branch ) it does connect your camera to the script?

Splinter0 commented 7 years ago

screenshot from 2017-02-24 20-49-08

As you can see here in works

Splinter0 commented 7 years ago

The problem is here, but i don't see any problem in this piece of code : @KonradIT screenshot from 2017-02-24 20-58-07

KonradIT commented 7 years ago

I just tested master w/ HERO4 Black, it works.

Splinter0 commented 7 years ago

Oh my god, that doesn't make any sense! @KonradIT

Splinter0 commented 7 years ago

Hey i found why... basically in some gopro camera the ping doesn't work sometimes. I fixed it now i'm gonne write it better and i'll push it @KonradIT

Splinter0 commented 7 years ago

Pushed, check if now it works @KonradIT

KonradIT commented 7 years ago

Getting there, but the /bacpac/sd on HERO4 does not exist so either use /gp/gpControl or use manual passwd input.

Splinter0 commented 7 years ago

ok i'll fix it, but it's weird because it shouldn't look for the password if it is an HERO4... Anyway thanks a lot ( I appreciate it a lot ) @KonradIT

Splinter0 commented 7 years ago

Uh and by the way i'll probably put my hands on a GoPro Karma soon ;) @KonradIT

KonradIT commented 7 years ago

@Splinter0 cool! I will probably get Karma V2. You'll need a HERO4 or HERO5 for the Karma FYI. I have firmware dumps of Karma Remote and it does look interesting. Would be cool if you could sniff the comms between GoProPassenger App and Karma Remote.

Splinter0 commented 7 years ago

That is what i was thinking... Where did you get the dumps? Did you sniff them? Uh also i have a friend with an HERO5 Black, so i'll probably ask him if i can use it for a while. @KonradIT Uh also, do you think i should put a manual password for the HERO4?

KonradIT commented 7 years ago

@Splinter0 I got them from gopro-fw-dl which is a python script to manually update gopro cameras and drones apparently. For HERO4, you should use their new API. Check out my py lib or DenisCarriere's lib

Splinter0 commented 7 years ago

ok thanks a lot, but i already have commands i need for the HERO4. the problem is with HERO5 @KonradIT

KonradIT commented 7 years ago

Just saw the commit, will test.

Splinter0 commented 7 years ago

Thanks @KonradIT

KonradIT commented 7 years ago

http://i.imgur.com/2Gy2XqE.png

Still does not work as intended, when Y then it just displays the error again.

Splinter0 commented 7 years ago

The issue is really weird : screenshot from 2017-02-27 20-51-49 As you can see, the detect function returns a boolean value to passReq, since ( as you can check on the code ) the HERO4 returns a False value, the while loop that tries to get the password shouldn't even start. But i'm gonna commit a new code that is gonna print the value of passReq. It should be False for the HERO4, if it's not please let me know. @KonradIT