search

SplitScreen-Me / splitscreenme-nucleus

Nucleus Co-op is an application that starts multiple instances of a game for split-screen multiplayer gaming!
https://www.splitscreen.me/docs/what-is-splitscreen-me
GNU General Public License v3.0
856 stars 50 forks source link

Update GameManager.cs #45 #46

Closed mikebarrett19 closed 1 year ago

mikebarrett19 commented 1 year ago

see #45

Mikou27 commented 1 year ago

Hi, that's very interesting and it's among the most requested features/changes. I'm not familiar with assemblies for now, so i will have to take the time ro review it correctly. Maybe we could get in touch if you're interested at contributing more to the project? EDIT: I forgot to ask you if you have finally got it to work the way you want with Playnite.

Snailedlt commented 1 year ago

@mikebarrett19 did you get it working with playnite? :)

mikebarrett19 commented 1 year ago

@Mikou27 @Snailedlt Sorry y'all, work has been busy and your messages got lost. I haven't gotten it to work with playnite, it wasn't as "drop in" as I thought it would be, as so much of the configuration is based in the gui. I plan to take another crack at it one of these days, I'll probably need to contribute default controller to screen mappings or something. It's up to you guys what to do with this pull request. We could close it until I get something working in playnite. I doubt I'll get to it until at least this summer. I'm not a C# developer by trade, but I plan on using contributions to this and playnite to learn C# in my free time. I need the assembly source changed because when I run nucleus dlls from another application (playnite) the directories are incorrect because they're sourced from the main application. But since I'm new to C# and windows development in general I have no idea the implications of this change, just that it fixes the directory problem. I can look into other fixes if this causes some issues. Appreciate y'all!

Snailedlt commented 1 year ago

I'm not actively working on the project, so @Mikou27 should decide what to do with the PR :)