Not a depending class is loaded.

Spliterash / MusicBox

Music plugin for spigot

11 stars 11 forks source link

Not a depending class is loaded. #1

Closed FPSUsername closed 2 years ago

FPSUsername commented 3 years ago

On server startup, I receive this warning. Latest at the time Paper 1.16.4 server NoteblockAPI development build (the latest release give the same error).

[12:49:25 WARN]: [MusicBox] Loaded class com.xxmicloxx.NoteBlockAPI.songplayer.PositionSongPlayer from NoteBlockAPI v1.6.1.1-SNAPSHOT which is not a depend, softdepend or loadbefore of this plugin.

This warning can also be related to a same type of warning with Vault issue 789. In that case, it's understandable.

koca2000 commented 3 years ago

Can be fixed by changing

https://github.com/Spliterash/MusicBox/blob/2a403d55f6b7b9b0df9f51c5986b0551cea50fed/src/main/resources/plugin.yml#L5

to depend:.

It may also solve #4.

FPSUsername commented 3 years ago

Correct, see Optional Attributes of the Plugin.yml file.

mibby commented 3 years ago

@koca2000 Adding NoteBlockAPI as a dependency to Musicbox would fix the sync task call error on shutdown if active, with ticket #4?

koca2000 commented 3 years ago

@mibby I think it would because it looks like NoteBlockAPI is already disabled when MusicBox calls SongPlayer.destroy().

Spliterash commented 2 years ago

Finnaly fix this, thanks guys