search

Spliterash / MusicBox

Music plugin for spigot
11 stars 11 forks source link

I would like to see a option to enable extra octave support in Noteblock API #10

Closed chengts95 closed 9 months ago

chengts95 commented 3 years ago

Since the extra octave can improve the nbs music a lot.

Spliterash commented 3 years ago

My plugin use noteblockapi for parse and play music, so i think if noteblock api can play extra octave, then my plugin can too

chengts95 commented 3 years ago

My plugin use noteblockapi for parse and play music, so i think if noteblock api can play extra octave, then my plugin can too

Yes but by default the extra octave is disabled since it requires extra resource pack. So plugin needs to enable it. Please take a look at this.

joex92 commented 3 years ago

Since the extra octave can improve the nbs music a lot.

actually that's a Minecraft limitation... not a plugin limitation... obviously you could add more octaves with resource packs, because you would be adding the octaves exaternally, but without adding something extra to both sides (client and server) you'll never get more than the octaves Minecraft already gives...

chengts95 commented 3 years ago

yes, but there is an extra resource pack by OpenNBS and NoteBlock API itself has a selective resource pack for more octaves. That is why the Noteblock API makes it an option. I have tested the extra octaves and it is awesome! this mod is the only one to expose the API.

joex92 commented 3 years ago

well first of all is not a mod, is a plugin... but I get it... I believe that mainly server owners prefer their servers to not make players download anything extra to be able to enter the server, otherwise just have a modded server instead of plugins... so I believe that's the reason, but it's true, it wouldn't hurt anyone to support the resource pack... and this could be the first one to do it, at least the first free plugin to do it...

chengts95 commented 3 years ago

the server-side resource pack is a native MC functionality and many plugins are using it for custom items. And all I suggest is to have a better audio experience with these plugins, especially when the NoteBlock API already has this option.

joex92 commented 3 years ago

well... the server-side thing is not just server-side... when the server sets a resource pack, it sends it to the client joining and, personally, sometimes that is annoying, specially if you are connecting from a low end PC, the processing of downloading and loading the RP takes too much time sometimes, and on some few cases the server can kick you for taking too much time at login... that's something server owners have to keep in mind... there are workarounds, like WorldResourcePack plugin, that lets you send the RP with a delay of X ticks, but still is annoying...

Nevertheless, it would be good to add that functionality to the plugin, I haven't seen it in other free NBS plugin...

Spliterash commented 9 months ago

Implemented in PULL request #31