search

Spliterash / MusicBox

Music plugin for spigot
11 stars 11 forks source link

[Bug] Impulse at song ending not working (1.16.5) #12

Closed joex92 closed 3 years ago

joex92 commented 3 years ago

when using the music sign, at the end of the song the impulse signal is not sending a redstone signal, it is triggering the lever, but it's not sending any redstone signal...

joex92 commented 3 years ago

I suggest to change it a bit... because having to add a lever behind is a bit "bothersome", specially if you want to build something small or not too big... maybe add the possibility to just connect redstone behind it and that way send the ending song impulse directly to the redstone, instead of using a lever... or instead of a lever use a repeater or a comparator... maybe a comparator makes more sense...

Spliterash commented 3 years ago

I cannot send a red signal from the void, these are not mods. I did it the way it was done in CraftBook. Even to be honest, I took the code from there

joex92 commented 3 years ago

hmm, I know is not a mod, but aren't you sending it from the sign? but still, the lever is not sending any redstone signal... the lever is only being changed the state but not acting like it was activated...

Spliterash commented 3 years ago

What version you use, im check on 1.12.2 and all work

joex92 commented 3 years ago

I'm on a paper fork 1.16.5... it's on the issue's title...

Spliterash commented 3 years ago

Oops, dont see, ok im check24 июн. 2021 г. 2:37 пользователь Joe X @.***> написал: I'm on a paper fork 1.16.5... it's on the issue's title...

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

Spliterash commented 3 years ago

Fixed in 2.0.5 It will be out tomorrow