search

Spliterash / MusicBox

Music plugin for spigot
12 stars 11 forks source link

Add midi support from NoteBlockAPI PR #2

Closed mibby closed 3 years ago

mibby commented 3 years ago

Do you think it would be possible to branch MusicBox and add support for the upcoming midi support? https://github.com/koca2000/NoteBlockAPI/pull/56

Spliterash commented 3 years ago

This thread is not yet merged with NoteBlockAPI. This is only possible if you compile this branch yourself. I am only for this opportunity, but until it appears in NoteBlockAPI, I can not do anything

mibby commented 3 years ago

Sure I suppose. I did compile the fork and it's likely the PR would be merged since the contributor has other PRs merged in the main branch. Just wanted to get a head start on the feature being readily available once merged.

Spliterash commented 3 years ago

"Как только, так сразу", or in English, as soon as there is a merger, I will immediately do

mibby commented 3 years ago

Wonderful. I'll be happy to help test when it happens.