search

SplitmediaLabsLimited / xjs

XSplit JS Framework. Make plugins for XSplit Broadcaster, quickly and easily.
Other
39 stars 11 forks source link

Dialog result not being returned by a spawned new dialog #115

Closed SML-MeSo closed 7 years ago

SML-MeSo commented 8 years ago

This issue is encountered in the current internal builds for XBC. This is due to the CEF update which now uses Chrome 52 (of which Object.observe is removed). Proposed resolution is to switch implementation to using proxies instead.

ghost commented 8 years ago

All looks well... though I think we can just make it a habit not to use var... use let instead if we're going to modify the variable, else, use const.

https://github.com/xjsframework/xjs/commit/9a7edb03f47413a4642733b41d89495814d346f7#diff-961e415905a925e60847a1e0066ec781R10

Ref: http://programmers.stackexchange.com/a/274352

ghost commented 7 years ago

I just realized that this would break the plugins that uses dialog.ts in the current latest public version of XSplit Broadcaster :((

We should add some version checkers on dialog.ts (use Proxy if version 2.9+, else, use Object.observe). And since you just got married and is on a honeymoon period, I'll do the fixes <3

ghost commented 7 years ago

Assigning to @SML-MeSo for review before pushing to release branch