search

SplitmediaLabsLimited / xjs

XSplit JS Framework. Make plugins for XSplit Broadcaster, quickly and easily.
Other
39 stars 11 forks source link

Unable to replace device of Live sources (CameraSource, AudioSources) via setValue #160

Closed SML-MeSo closed 6 years ago

SML-MeSo commented 7 years ago

Live sources are, by default treated and fixed as global sources. This takes special implementation on XBC core, which could have lead to setting prop:srcitem on them to fail. They can only be set using prop:item and should be considered in the setValue method

SML-MeSo commented 7 years ago

This fix may not be needed anymore as latest internal builds of XBC already addresses it. The catch is, live sources are always linked when the same device is added, unlike other sources wherein you need to explicitly duplicate/paste a linked item. Therefore using prop:srcitem for live sources and batch-changing all items of the same device may not be the intended behavior.

As per discussions with @mikeybanez to further differentiate between items and sources, new proposed behaviour is that calling setValue via item object will only change the item (indicidually, automatically unlinking it if previously linked) and calling it via source object will batch-change all linked items.

Moving to 2.5.0 as it may merit more implementation time.