search

SplitmediaLabsLimited / xjs

XSplit JS Framework. Make plugins for XSplit Broadcaster, quickly and easily.
Other
39 stars 11 forks source link

Added property `types` in package.json #188

Closed cecilemuller closed 6 years ago

cecilemuller commented 6 years ago

VSCode Intellisense couldn't find the module definition because the NPM package didn't have a property "types" that points to index.ts

cecilemuller commented 6 years ago

Feel free to ask if you have any questions 😃

It's just one line, with no adverse side-effects, and the link to the Typescript docs even shows it's the recommended way to do it.

virn commented 6 years ago

We're already planning on merging this on our upcoming release this week. Though, shouldn't the declaration be named as index.d.ts ?

cecilemuller commented 6 years ago

That's great 😃

And no, it can point to a regular .ts file as well.

If you have VSCode, you can even try this boilerplate to see the effect of the line change (just close and re-open VSCode after adding the line to make sure it notices the change).

mikeybanez commented 6 years ago

@virn I think best thing to do here is to recreate this commit in another branch, because this MR merges straight to master (every master commit in our workflow is intended to be a full version release).

cecilemuller commented 6 years ago

Sure, if you prefer I can close the PR. It's just one line anyway.