Scene add and delete events do not fire on remote

SplitmediaLabsLimited / xjs

XSplit JS Framework. Make plugins for XSplit Broadcaster, quickly and easily.

Other

39 stars 11 forks source link

Scene add and delete events do not fire on remote #197

Closed virn closed 6 years ago

virn commented 6 years ago

Per checking proxy still returns the old format for settingsObj on EventManager which results to error in parsing in remote. There should be additional parameters here for checking and matching the callbacks.

I also noticed that different events were called for proxy and remote.

Will be checking other instances as well that may have been affected with the recent changes.

virn commented 6 years ago

Additional update on this, new ExtensionWindow events bscn-load and scene-delete-all do not fire.

The fix for scene-delete-all is the same for current item.
bscn-load on the other hand poses a different issue. On the event of trying to trigger the event, it causes the web socket connection to break. (Will continue to investigate cause)

cc @SML-MeSo