getCurrentSource returns basic Source object, not the type-specific ones

SplitmediaLabsLimited / xjs

XSplit JS Framework. Make plugins for XSplit Broadcaster, quickly and easily.

Other

39 stars 11 forks source link

getCurrentSource returns basic Source object, not the type-specific ones #221

Closed ErickRodrCodes closed 5 years ago

ErickRodrCodes commented 6 years ago

Requirements: XBC 3.4 XJS 2.8.1

example:

 xjs.ready()
  .then(Item.getCurrentSource)
  .then(function(item) {
    myItem = item;
    return item.loadConfig();
  })

error: loadConfig is not defined on item.

reverting to XBC 3.3 fixes the issue. XJS 2.8.1 working fine on XBC 3.3

mikeybanez commented 6 years ago

@SML-MeSo, this would be good to check now, to verify if the app needs to be patched (we are planning an upcoming M37-FB update).

SML-MeSo commented 6 years ago

Upon checking, issue may have been brought about by the changes for #216. Please note that issue can only be replicated in the minified version. For fixing

ErickRodrCodes commented 6 years ago

checked with the provided source, still getting null on Item.getCurrentSource() promise:

Not sure what to do at the moment, but this is leaving me to tell my client to wait until a definitive fix appears.