search

SplitmediaLabsLimited / xjs

XSplit JS Framework. Make plugins for XSplit Broadcaster, quickly and easily.
Other
39 stars 11 forks source link

Append license file to dist files #75

Closed ghost closed 8 years ago

ghost commented 8 years ago

We should append the license file to xjs.js, xjs.min.js, and xjs-es2015.js

mikeybanez commented 8 years ago

@dcefram is there a valid reason why this is not part of the default build task?

ghost commented 8 years ago

None really, just aesthetics.

Compare:

/**
 * XSplit JS Framework
 * version: 1.2.0
 **/
/**
 * LICENSE here
 **/

vs

/**
 * XSplit JS Framework
 * version: 1.2.0
 *
 * LICENSE here
 **/

We could've done it on both the default task and the version up task, but it would be redundant. I decided to just add it on the version up task since we'll always use the version up when we push to master.

mikeybanez commented 8 years ago

Item is ready for release. @SML-MeSo @virn please take note that we now need to run gulp version major|minor|patch when pushing out any new release. The default gulp task does not add any license header.