search

Splitwirez / AvaloniaRibbon

Ribbon for avalonia
MIT License
101 stars 22 forks source link

Property "Background" doesn't work for "RibbonGroupBox" #17

Closed f0xeri closed 3 years ago

f0xeri commented 3 years ago

Foreground works well, but background doesn't work for RibbonGroupBox. Color is unchangeble.

seljmov commented 3 years ago

@f0xeri Hi! I looked through the source code and realized that this happens due to the absence of the Background="{TemplateBinding Background} " parameter in the panel in line 43 here - Fluent Theme RibbonGroupBox or in line 44 here - Default Theme RibbonGroupBox. This is a develop-branch that supports Avalonia 10.0.

You can replace these lines:

You'll get something like this: image

f0xeri commented 3 years ago

It works, thanks.

Splitwirez commented 3 years ago

I've just integrated a fix for this into the develop branch, which should cause the Background property to be respected, as requested. Sorry for the inconvenience.

@f0xeri For future reference, could you please elaborate on your use case for this? It's always useful to know more about how people are using AvaloniaRibbon and how they would like to be able to use it, so that I can plan accordingly and better serve those needs.

Also @seljmov thank you for pointing out an interim solution.

seljmov commented 3 years ago

Not at all, @Splitwirez, thank you for the project) I actively use AvaloniaUI in my project and am happy to help it with development)