search

Splitwirez / avalonia-aero-theme

https://github.com/Splitwirez/avalonia-aero-theme
129 stars 7 forks source link

Add Demo.Desktop and Demo.Android to solution #5

Closed Neurofibromin closed 2 months ago

Neurofibromin commented 3 months ago

as mentioned in: https://github.com/Splitwirez/avalonia-aero-theme/issues/4#issuecomment-2158383322 This allows IDEs to recognise all projects as part of the solution.

Splitwirez commented 3 months ago

@Neurofibromin So sorry for not getting back to you on this in a more timely manner - just as our discussion over in https://github.com/Splitwirez/avalonia-aero-theme/issues/4 was picking up, some stuff...uh...came up. I haven't forgotten though!

(mind you, if I don't get back to you properly in another 2 weeks' time, it might've actually slipped my mind, so please don't hesitate to @mention me at that point)

Neurofibromin commented 2 months ago

@Splitwirez

Splitwirez commented 2 months ago

@Neurofibromin So sorry for the delay...would've happened way sooner, but I somehow mistakenly thought you were PR-ing to main...

Problem

Your change to build/dotnet-version.props interferes with building via e.g. dotnet run outside of Visual Studio.

Can you verify whether or not changing line 5 in that file to

<PropertyGroup Condition=" ('$(VisualStudioMajorVersion)' != '') AND ('$(VisualStudioMajorVersion)' >= '17') ">

still allows building with .NET 8 on your end? (and I guess make that change, if it does)

Neurofibromin commented 2 months ago

I changed the line and it works. Added the commit.

Splitwirez commented 2 months ago

@Neurofibromin Merged :+1: