Splizard / minetest-mod-snow

Adds snow biomes to Minetest.
http://splizard.com/minetest/mods/snow-biomes/
Other
10 stars 9 forks source link

Rewrite stairs code. #32

Closed fozolo closed 6 years ago

fozolo commented 6 years ago
HybridDog commented 6 years ago

Thank you for revising this. MTG itself also registers ice and snowblock stairs: https://github.com/minetest/minetest_game/blob/master/mods/stairs/init.lua#L784 So when using MTG stairs, the original ones are overriden. Is this intended?

fozolo commented 6 years ago
83      if not minetest.registered_nodes["stairs:stair_" .. name] then
84          stairs.register_stair(name, nodename, groups, images, desc_stair, sounds)
85      end
86
87      if not minetest.registered_nodes["stairs:slab_" .. name] then
88          stairs.register_slab(name, nodename, groups, images, desc_slab, sounds)
89      end

Yes, they are intentionally overridden to adjust their groups and the use_texture_alpha property. The check on lines 83 and 87 to prevent duplicate registrations was in fact a bug left over from some other experiment. This prevented the new groups from being set for ice and snowblock and has now been corrected.

Moreblocks stairsplus may soon register ice and snowblock as well (minetest-mods/moreblocks#109), but they are intentionally overridden for the same reasons.