Ctrl+W closes pomotroid instance

Splode / pomotroid

:tomato: Simple and visually-pleasing Pomodoro timer

https://splode.github.io/pomotroid/

MIT License

4.36k stars 369 forks source link

Ctrl+W closes pomotroid instance #121

Closed johnjacobkenny closed 4 years ago

johnjacobkenny commented 4 years ago

Today I unknowingly pressed Ctrl+W when pomotroid was active. I'm on Linux using the AppImage. It closed (as you would expect a browser tab to close).

However for an app like this, I don't think that is an expected behavior? What do you folks think?

If this behavior can/should be changed, I would like to contribute. :smiley:

Splode commented 4 years ago

Hi @johnjacobkenny. No, I think you're right: that's not expected behavior.

Any contributions are welcome!

johnjacobkenny commented 4 years ago

A quick search brought me to an SO page. Here are the three options that are suggested, which do you suggest would be optimal?

Menu.setApplicationMenu(null) // would remove default application menu
browserWindow.setMenu(null) // would remove menu for the current window
globalShortcut.register("CommandOrControl+W", callback) // would capture the specific key combo and do nothing

Splode commented 4 years ago

@johnjacobkenny,

Here are the three options that are suggested, which do you suggest would be optimal?

The second option, using the setMenu method, is probably the simplest and most straight-forward. We don't use any other default menu items, so removing it shouldn't be an issue.