feat: Add option to disable tick sounds during break

Splode / pomotroid

:tomato: Simple and visually-pleasing Pomodoro timer

https://splode.github.io/pomotroid/

MIT License

4.36k stars 369 forks source link

feat: Add option to disable tick sounds during break #125

Closed johnjacobkenny closed 4 years ago

johnjacobkenny commented 4 years ago

Closes #124

Please let me know if any changes are needed. All feedback is appreciated. :slightly_smiling_face:

Splode commented 4 years ago

Thank you, @johnjacobkenny, for the contribution! I think it's a great addition.

However, there's an issue with the new feature. If the option Tick Sounds - Work is unchecked, but Tick Sounds - Break is checked, the tick sounds will not play.

johnjacobkenny commented 4 years ago

I have changed the logic and tested it. Please let me know if the logic looks good and maintainable, or how you might do it differently

Splode commented 4 years ago

@johnjacobkenny looks good, thank you for the contribution!