search

Splode / pomotroid

:tomato: Simple and visually-pleasing Pomodoro timer
https://splode.github.io/pomotroid/
MIT License
4.36k stars 369 forks source link

Global shortcuts added. Issue #33 #129

Closed AliLozano closed 4 years ago

AliLozano commented 4 years ago

Hi!

Here my pull request for shortcuts.

It don't supports shortcuts that include Meta keys(Cmd / Win).. but for the moment It works with other shortcuts.

Thanks.

Splode commented 4 years ago

Hi @AliLozano thank you for the contribution!

This is a great start to an often requested feature.

I'm not sure why the Super key doesn't bind correctly, either. I need to do more research.

I'll probably alter the styling of the key input when focused as any existing text is difficult to read. See image.

screenshot of Pomotroid settings

All in all, thanks again! 👏🏼🚀

Splode commented 4 years ago

@AliLozano Oh, and thank you for adding the log-to-console utility to the logger--that's helpful 👍🏼

AliLozano commented 4 years ago

@Splode I didn't see that text, my intention was that when is focused, hide the text.. but it's ok if you change it.

For the super key, I think that is not captured by keypress as modifier, if no as another normal key. Some libraries handle this saving the previous key in a temp variable, but... I didn't test it.

And about the log, It was neccesary.. I lost more time trying to understand loggers that implementing the pull request. First I was wondering why logs are no printed(I thought I was doing something wrong) and after why my console.log was no printed in the main.js, after I understood that the js runs in to environs node(SO) and webbrowser(Vue) :v.

Thanks for accepting my pull request.