search

Splyth / slack_bot

Slack Bot Created for the Animutiny Slack Group (Name is Lisa)
MIT License
9 stars 5 forks source link

Secret PR Don't Tell Anyone Shhh! #69

Closed Splyth closed 4 years ago

Splyth commented 4 years ago

@jedibob5 @Mill1893 and anyone else who can keep a secret

This PR adds a couple of fun easter eggs.

My bro Eric did some good photoshop work and made two cute Lisa pictures. One with a witch hat. And another with a Santa hat. I found out I can get Lisa to display those images (and a custom name to boot) during October and December.

But I don't want the rest of the Slack to know cause it's way more fun this way. So if you're reading this PR. You're officially sworn to secrecy. Pinky Promise no take backs!

Splyth commented 4 years ago

Added Easter (PS that holdiay is floating mess of misery and pain.) Eric says he's gonna do a birthday hat which I'm going to use for https://github.com/Splyth/slack_bot/issues/14 and https://github.com/Splyth/slack_bot/issues/15

Splyth commented 4 years ago

@Mill1893 @jedibob5 @Zylox (yeah I saw you peeking XD) this is ready for a review it closes https://github.com/Splyth/slack_bot/issues/14 and https://github.com/Splyth/slack_bot/issues/15

Also double check I already had one oops.

P.S By pure happenstance this is PR Number 69 awwww yeah!

Splyth commented 4 years ago

That Easter calculation is hairy but I'm gonna presume the logic is correct. Beyond that, looks good, and the icons are great.

I stole that, checked that it worked for a few dates and said Close Enough. Because Easter is a PITA. It can fall anywhere from March 22nd to April 25th. Depending on the phases of the moon (I'm not even kidding)

I'll let Eric know you like them 👍

Splyth commented 4 years ago

Confirmed the links are working as expected.

I think Eric is tired of making hats for now.

There's only a few more that I'd even think we'd want but they'd have much shorter durations

New Years would just be the day. A few days around Valentine's Day A few days around St. Patricks Day And a week or so before the 4th of July

But really those are just bonus laps. We got all the major ones.