Turning a quest in and then taking it error(s) out

Spodii / netgore

Cross platform online rpg engine using C# and SFML

http://www.netgore.com/

40 stars 16 forks source link

Turning a quest in and then taking it error(s) out #343

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

"Quest list already contains the quest 'DemoGame...'

This happened after turning the brawler quest in and then attempting to take it 
again right after - also happens in the SQL dump on the previous related issue 
with quest kill counters.

Original issue reported on code.google.com by hilts.va...@gmail.com on 9 Feb 2013 at 8:04

GoogleCodeExporter commented 9 years ago

Seems like it's trying to add the kill counter again if it's not found (not 
sure why this is happening; querying for quest requirements after the fact. I'm 
hoping Spodiii has got some insight.)

Original comment by hilts.va...@gmail.com on 9 Feb 2013 at 9:03

GoogleCodeExporter commented 9 years ago

I don't remember much at all about the quest stuff. I think the "add the kill 
counter again if its not found" may be in case it fails to get added correctly 
the first time. Sorry I can't be of much help. :/

Original comment by Spodiii on 10 Feb 2013 at 6:20

GoogleCodeExporter commented 9 years ago

I can't reproduce this. Are you sure this is a bug with vanilla NetGore?

Original comment by darksumm...@gmail.com on 10 Feb 2013 at 7:08

GoogleCodeExporter commented 9 years ago

I think it was fixed in your latest revision; testing...

Original comment by hilts.va...@gmail.com on 10 Feb 2013 at 7:13

GoogleCodeExporter commented 9 years ago

False. And according to Skype, you meant the wrong thing, too. ;p

Original comment by hilts.va...@gmail.com on 10 Feb 2013 at 7:23

GoogleCodeExporter commented 9 years ago

I just tested with vanilla NetGore (latest rev 4745) and yes, this bug does 
exist.

Original comment by darksumm...@gmail.com on 10 Feb 2013 at 7:24

GoogleCodeExporter commented 9 years ago

I've got an idea on why this is occurring... let me at it!

Original comment by hilts.va...@gmail.com on 13 Feb 2013 at 2:20

Changed state: Started

GoogleCodeExporter commented 9 years ago

I've debugged this a bit and it's quite frustrating. I can't seem to fix it but 
I know why this error is happening. When you finish the quest, it clears the 
kill counter as expected but it then also checks again and because it's empty, 
it goes ahead and adds a new kill counter (why? I have no idea). Thus, when you 
go to accept the repeatable quest again, this error will always appear, because 
there will always be a kill counter set.

Original comment by darksumm...@gmail.com on 14 Feb 2013 at 11:23

GoogleCodeExporter commented 9 years ago

Ok I've fixed it, but I'm not sure if it's a little "hacky". Since it's such a 
small change I'll commit it and let you or Spodi decide if it should be done 
differently.

Original comment by darksumm...@gmail.com on 14 Feb 2013 at 11:35

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r4753.

Original comment by darksumm...@gmail.com on 15 Feb 2013 at 12:10

Changed state: Fixed