search

Spomky-Labs / cbor-php

CBOR Encoder/Decoder for PHP
MIT License
42 stars 11 forks source link

Editorial nits #27

Closed cabo closed 2 years ago

cabo commented 2 years ago
Q A
Bug report? yes/no
Feature request? yes/no
BC Break report? yes/no
RFC? / Specification yes/no
Library version x.y(.z)
Documentation . yes

Two Three quick editorial comments on the README:

Spomky commented 2 years ago

Hi,

Thank you for the documentation review. I've just address the changes except for the first point. I have to make sure this does not imply any other changes.

It looks like class names should be changed as well. For example, UnsignedIntegerObject should be PositiveIntegerObject (or just PositiveInteger).

cabo commented 2 years ago

On 2021-07-27, at 16:24, Florent Morselli @.***> wrote:

It looks like class names should be changed as well. For example, UnsignedIntegerObject should be PositiveIntegerObject (or just PositiveInteger).

Actually, not all unsigned integers are positive: 0 is the exception.

That is the reason why CBOR has unsigned integers (major type 0, 0…) and negative integers (major type 1, …-1).

(This is the difference between cardinals and ordinals that has been plaguing discussions of “natural numbers” for ages. Computers have made a clear selection for cardinals here.)

Grüße, Carsten

Spomky commented 2 years ago

Hi @cabo,

Your comments are going to be addressed by #31.

I close this issue now. Feel free to open it or comment if needed. Regards

cabo commented 2 years ago

On 2021-09-15, at 08:33, Florent Morselli @.***> wrote:

InfiniteLength

Really Indefinite Length (note the “de”).

Thanks!

Grüße, Carsten

Spomky commented 2 years ago

Yes. Just a typo. Indefinite length is what I meant to write. https://github.com/Spomky-Labs/cbor-php/blob/Preparation2.0/src/InfiniteListObject.php#L17

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.