allow method chaining - Githubissues

Spomky-Labs / otphp

:closed_lock_with_key: A PHP library for generating one time passwords according to RFC 4226 (HOTP) and the RFC 6238 (TOTP)

MIT License

1.31k stars 150 forks source link

allow method chaining #205

Open browner12 opened 9 months ago

browner12 commented 9 months ago

Target branch: Probably a new major, with the interface change? Resolves issue NA

[ ] It is a Bug fix
[x] It is a New feature
[x] Breaks BC
[ ] Includes Deprecations

Allow users to chain methods when building their OTP.

I believe this breaks BC, and warrants a new Major due to the interface change.

Spomky commented 9 months ago

Hi,

Many thanks for this PR. This is a nice feature. Let me see how to manage the changes regarding the BC break. I could take the opportunity to drop PHP 8.1 that entered in the security fix only release phase.