search

Spomky-Labs / otphp

:closed_lock_with_key: A PHP library for generating one time passwords according to RFC 4226 (HOTP) and the RFC 6238 (TOTP)
MIT License
1.31k stars 150 forks source link

Explicitly set arg_seperator #210

Closed ziegenberg closed 6 months ago

ziegenberg commented 6 months ago

We cannot rely on arg_separator.output to be set to it's default '&', therefore we explicitly set it here.

Target branch: 11.3.x

ziegenberg commented 6 months ago

I added a test.

ziegenberg commented 6 months ago

The failing rector tests are probably due to https://github.com/rectorphp/rector/issues/8395.

Spomky commented 6 months ago

Thanks. That's a nice addition. Waiting for CI to pass.

Spomky commented 6 months ago

No worries for Rector. I will fix it.

ziegenberg commented 6 months ago

I found this while I was working on this: https://tracker.moodle.org/browse/MDL-79678

If we could have a version that includes this fix soon, that would be wonderful.

Spomky commented 6 months ago

Excellent. Can you target 11.2? It seems it is more a big fix than a new feature.

ziegenberg commented 6 months ago

I'll rebase onto branch 11.2.x and force push. Is that okay with you?

ziegenberg commented 6 months ago

Rebased and force-pushed.

Spomky commented 6 months ago

Many thanks 👍🏼

ziegenberg commented 6 months ago

Many thanks for the quick release! 🎉