search

Spomky-Labs / pwa-bundle

PHP library for generating a full featured PWA manifest
https://pwa.spomky-labs.com
MIT License
28 stars 1 forks source link

Add favicon support, configuring and processing methods #187

Closed Spomky closed 2 weeks ago

Spomky commented 3 weeks ago

This addition introduces favicon support, including the configuration and processing methods. A DTO for favicons was added along with config definition. Moreover, the relevant processing logic was also implemented in both GDImageProcessor and ImagickImageProcessor. Other affected components have been adjusted accordingly to accommodate these changes.

Target branch: 1.2.x Resolves issue #66

Spomky commented 3 weeks ago

Final icons should contain a hash in their path.

tacman commented 3 weeks ago

Sweet! This is a nice bonus.

So many awesome new features, do you plan on updating pwa-demo? It'd be great to see these in action.

On Thu, Apr 25, 2024, 2:12 PM Florent Morselli @.***> wrote:

Final icons should contain a hash in their path.

— Reply to this email directly, view it on GitHub https://github.com/Spomky-Labs/pwa-bundle/pull/187#issuecomment-2077876827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQIHSJQIJIP5RMVAUQTY7FBRZAVCNFSM6AAAAABGZLWO5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXHA3TMOBSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>