search

Spomky-Labs / pwa-bundle

PHP library for generating a full featured PWA manifest
https://pwa.spomky-labs.com
MIT License
28 stars 1 forks source link

need default for favicons #188

Closed tacman closed 2 weeks ago

tacman commented 3 weeks ago

Version(s) affected

1.2.x

Description

 composer req spomky-labs/pwa-bundle:1.2.x
./composer.json has been updated
Running composer update spomky-labs/pwa-bundle
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking spomky-labs/pwa-bundle (1.2.x-dev 826b264)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Downloading spomky-labs/pwa-bundle (1.2.x-dev 826b264)
  - Installing spomky-labs/pwa-bundle (1.2.x-dev 826b264): Extracting archive
Generating autoload files
150 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Endroid Installer detected project type "symfony"

Symfony operations: 1 recipe (ec6fe2ae6171505205c893eb05cc437e)
  - Configuring spomky-labs/pwa-bundle (>=1.2.x-dev): From auto-generated recipe
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!  
!!  In SpomkyLabsPwaBundle.php line 54:
!!                                             
!!    Warning: Undefined array key "favicons"  
!!                                             
!!  
!!  
Script @auto-scripts was called via post-update-cmd

How to reproduce

see above

Possible Solution

No response

Additional Context

No response

Spomky commented 3 weeks ago

Hi,

This is a strange behavior because the section definition hascanBeEnable() that provides defaults when missing. I cannot reproduce here. Can you use the last branch update (I psuhed changes few minutes ago)

tacman commented 2 weeks ago 
symfony new pwa-bundle-issue --webapp && cd pwa-bundle-issue 
composer config minimum-stability dev
composer req spomky-labs/pwa-bundle:1.2.x
Symfony operations: 1 recipe (5a857ece69e94caa95caca44cc36154d)
  - Configuring spomky-labs/pwa-bundle (>=1.2.x-dev): From auto-generated recipe
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!  
!!  In SpomkyLabsPwaBundle.php line 54:
!!                                             
!!    Warning: Undefined array key "favicons"  
!!                                             
!!  
!!  
Script @auto-scripts was called via post-update-cmd
Spomky commented 2 weeks ago

Should be fixed with the last update

tacman commented 2 weeks ago

yep, thanks!