SpongePowered / Configurate

A simple configuration library for Java applications providing a node structure, a variety of formats, and tools for transformation
https://configurate.aoeu.xyz
Apache License 2.0
386 stars 68 forks source link

hocon: fix round-tripping of extraneous comment indent #449

Closed jpenilla closed 1 year ago

jpenilla commented 1 year ago

fixes https://github.com/Hexaoxide/Carbon/issues/311 properly

zml2008 commented 1 year ago

This looks like it should be a good improvement, what are you thinking still needs to happen before this is undrafted?

jpenilla commented 1 year ago

Probably could have undrafted it earlier, rebased now though

Is it intentional that -vendor tests don't run on ci? I checked that typesafe-configs passed locally fwiw

zml2008 commented 1 year ago

That is not intentional I don't think, could use a test task in the root project that depends on the test tasks in the included vendor build