search

SpongePowered / Mixin

Mixin is a trait/mixin and bytecode weaving framework for Java using ASM
MIT License
1.41k stars 194 forks source link

Move to Gradle 7 for build script? #510

Closed LogicFan closed 3 years ago

zml2008 commented 3 years ago

why? there's no reason to update

LogicFan commented 3 years ago

Because Gradle 6 does not support Java 16. And this means any time I want to compile Mixin, I need to change my JAVA_HOME variable.

SizableShrimp commented 3 years ago

Not true. You can configure the JVM for Gradle from a gradle project property, which can also be done globally in your .gradle folder in your user directory, with the full path being ~/.gradle/gradle.properties

LogicFan commented 3 years ago

Not true. You can configure the JVM for Gradle from a gradle project property, which can also be done globally in your .gradle folder in your user directory, with the full path being ~/.gradle/gradle.properties

I cannot seem to get it to work project-wise. And is there any particular reason not to upgrade to Gradle 7?

SizableShrimp commented 3 years ago

Pretty sure the buildscript uses some FTP stuff removed in Gradle 7, so yes.

LexManos commented 3 years ago

Gradle 6.9 backported support for building J16 code. But does not ship the updated groovy and other libs that allow running gradle itself on J16.

I'll be speaking with mumfrey about bumping his scripts to a modern version now that some blockers have been removed. However its not super important so I haven't gotten around to it.