search

SpongePowered / Mixin

Mixin is a trait/mixin and bytecode weaving framework for Java using ASM
MIT License
1.41k stars 194 forks source link

Typo in Accessor.java #556

Closed Jack-Papel closed 2 years ago

Jack-Papel commented 2 years ago

https://github.com/SpongePowered/Mixin/blob/155314e6e91465dad727e621a569906a410cd6f4/src/main/java/org/spongepowered/asm/mixin/gen/Accessor.java#L71

On this line, it says maye instead of may.

Mumfrey commented 2 years ago

If the error doesn't in any way affect actually understanding the text, then it's seriously just not worth the overhead of the issue, a message in discord is perfectly adequate.

For example if the typo is "does" when it should be "doesn't", or "may" when it should be "must", there's an important semantic distinction to be made. Those are worth flagging. But a single-character typo that doesn't in any way affect the meaning - or even the parsing - of the sentence? Yeah, nah.

Jack-Papel commented 2 years ago

Sure. Thanks for the quick response. I'll head to the discord next time instead if I notice anything else.