search

SpongePowered / Mixin

Mixin is a trait/mixin and bytecode weaving framework for Java using ASM
MIT License
1.41k stars 194 forks source link

Missing toString override in GlobalProperties$Keys causes incorrectly named Keys due to string concatenation with existing Keys #562

Closed DJtheRedstoner closed 4 months ago

DJtheRedstoner commented 2 years ago

The lack of a toString override in GlobalProperties$Keys makes the following code (and other similar instances) create a key similar to org.spongepowered.asm.launch.GlobalProperties$Keys@239b0f9d.default. https://github.com/SpongePowered/Mixin/blob/155314e6e91465dad727e621a569906a410cd6f4/src/main/java/org/spongepowered/asm/mixin/MixinEnvironment.java#L1096

Mumfrey commented 2 years ago

Thanks for opening this, marked as bug.