SpongePowered / Ore

Repository software for Sponge plugins and Forge mods
https://ore.spongepowered.org/
MIT License
77 stars 25 forks source link

'Mixin' applied as platform despite META-INF/sponge_plugins.json existing #1066

Closed AuroraLS3 closed 1 year ago

AuroraLS3 commented 1 year ago

Describe the bug

My plugin uses one mixin and Sponge API 8. When I upload the plugin it is marked as 'Mixin' instead of 'Sponge 8.0', which prevents the newer version appearing as a promoted version

To Reproduce

I don't unfortunately know enough about the detection mechanism to say how to reproduce it other than use my plugin jar.

  1. Download latest from https://ore.spongepowered.org/AuroraLS3/Plan/versions
  2. Reupload

Expected behavior

Should be detected as Sponge 8.0

Screenshots

image image

Additional context

felixoi commented 1 year ago

Hey @AuroraLS3 I think something is wrong with your sponge_plugins.json? It does not contain

"dependencies": [
       {
          "id": "spongeapi",
          "version": "8.0.0",
          "load-order": "after",
          "optional": false
        },
       ...
]

as it should if it has a SpongeAPI dependency. Maybe try a clean rebuild? The correct behaviour should add both tags to the versions.

AuroraLS3 commented 1 year ago

Okay I think this might be an issue with the snapshot version of sponge vanilla gradle plugin instead - thanks for your input! :)