search

SpongePowered / Ore

Repository software for Sponge plugins and Forge mods
https://ore.spongepowered.org/
MIT License
79 stars 25 forks source link

Allow organizations to require 2fa #537

Open Aaron1011 opened 6 years ago

Aaron1011 commented 6 years ago

GitHub has a feature where organizations can require that all members have 2fa enabled for their respective accounts. It would be nice if Ore provided a similar feature for interested organizations.

phase commented 6 years ago

We can implement this in two ways:

  1. Don't allow the user to join the organization if it requires 2FA and they don't have 2FA.
  2. Let them join but don't allow them to do anything.

The second option would be harder to implement, and not checking every error could lead to a security issue, so I think the first option is the route we should go.

I'm scheduling this for v2.1 as I believe it won't be needed until then. Shout any objections.

Aaron1011 commented 6 years ago

https://github.com/SpongePowered/SpongeAuth/issues/183 will complicate this somewhat.