search

SpongePowered / Sponge

The SpongeAPI implementation targeting vanilla Minecraft and 3rd party platforms.
MIT License
391 stars 211 forks source link

Server stalls when reloading tracker configuration file #1978

Open PurpleIsEverything opened 6 years ago

PurpleIsEverything commented 6 years ago

I am currently running

The server stalls forever when running sponge reload -g after auto-populating and modifying tracker.conf There are no additional errors in any console logs and this stall-report was generated by the sampler mod created by the developer of Fastcraft.

This is likely caused by the large size 1MB+ of the tracker.conf file when populated on a large pack such as FTB Continuum.

Stall-report: https://gist.github.com/PurpleIsEverything/0a78143b4323dd1548c24b98b8f7c8d3

gabizou commented 6 years ago

@bloodmc @lucko maybe need to do the reload off thread and then sync back?

phit commented 5 years ago

this just happened to me with a completely empty tracker file.. i just enabled auto populate and ran sponge reload -t in a decent size modpack

lucko commented 5 years ago

Uhm, yeah reloading async would probably solve it, but also, a 1MB config file seems a bit much. Perhaps the format of that could be improved?

phit commented 5 years ago

well in my case the tracker.conf was actually empty and stock, i enabled auto-populate by editing the file and then ran the reload i think it then tried to auto-populate everything it knew about in one go which stalled the server until the watchdog killed it

not sure how the format could be improved, here's an example https://gist.github.com/phit/00da80dc0634ded42b21bd7d0e6a0480

there's just a lot of stuff in a big modpack

also here's the three stall reports it made before the watchdog killed it https://gist.github.com/phit/1a8ec1e6d77d370097da98fc7d4469c9