SpongePowered / Sponge

The SpongeAPI implementation targeting vanilla Minecraft and 3rd party platforms.
MIT License
389 stars 211 forks source link

Doc says fully customized skins are not possible while in fact they are #2089

Closed nihiluis closed 6 years ago

nihiluis commented 6 years ago

I am currently running

Issue Description i think I found wrong information in the docs. you can change the skin of any player and Human to anything you want ... you can just upload png to mineskin.org service and then he gives you signature and texture value base64 you want and need (same way you create skulls). see: https://wiki.citizensnpcs.co/Skins

    /**
     * Represents the {@link Key} for the skin of a {@link Humanoid}.
     *
     * <p>Skins can only be manipulated by supplying the UUID of a player
     * having that skin. The binary skin data is signed by Mojang so fully
     * customized skins are not possible.</p>
     *
     * @see SkinData#skinUniqueId()
     */
    public static final Key<Value<UUID>> SKIN_UNIQUE_ID = DummyObjectProvider.createExtendedFor(Key.class,"SKIN_UNIQUE_ID");
Cybermaxke commented 6 years ago

This is already fixed in bleeding, so for API8+, it won't be for API 7 because it caused breaking changes. Got fixed by this PR: https://github.com/SpongePowered/SpongeAPI/pull/1836

nihiluis commented 6 years ago

looks pretty good, hope its merged

Cybermaxke commented 6 years ago

Yeah, it's merged: https://github.com/SpongePowered/SpongeAPI/commit/a3431307f06996321489b69664b16202e8806042