Some mod commands are not correctly registered

SpongePowered / Sponge

The SpongeAPI implementation targeting vanilla Minecraft and 3rd party platforms.

MIT License

384 stars 211 forks source link

Some mod commands are not correctly registered #3692

Open johnfriedrich opened 2 years ago

johnfriedrich commented 2 years ago

Affected Product(s)

SpongeForge

Version

1.16.5-36.2.5-8.1.0-RC1134

Operating System

Linux

Java Version

Plugins/Mods

unknown

Describe the bug

Currently testing Pixelmon 9.0.0 on Sponge api8. A few commands are registered under the unknown prefix. As these commands work in pure forge, Mohist and Arclight I assume its sponge bug.

Only commands in the log are affected. All other commands are correctly registered

Link to logs

https://pastebin.com/MAr4vU2j

johnfriedrich commented 2 years ago

I am not 100% sure, but I think this happens when the Forge commands has aliases set. The reported commands are just aliases

dualspiral commented 2 years ago

That's not really a bug so much - though it shouldn't be marked as an error. Basically - we don't always get the information about which plugin has registered a command, usually because a mod does it out of the event cycle. That's what's happened here - we just have to say "we don't know, we tried".

I'd imagine those commands work without a prefix.

johnfriedrich commented 2 years ago

Hm no, when using one of these aliases LP does not check for a permission and it just says

All commands, even the failing ones are registered during "RegisterCommandsEvent"