search

SpongePowered / Sponge

The SpongeAPI implementation targeting vanilla Minecraft and 3rd party platforms.
MIT License
390 stars 211 forks source link

Add Keys.MAX_GROWTH_STAGE #4009

Closed MrHell228 closed 5 months ago

MrHell228 commented 5 months ago

I removed Keys.GROWTH_STAGE from saplings because it used STAGE property instead of AGE properties. And those 2 has to be differed because there is BambooStalkBlock that use both STAGE and AGE properties. So I think it would be better to keep only age-related blocks in this key.

aromaa commented 5 months ago

Saplings should still implement the Keys.GROWTH_STAGE. While the underlying property is STAGE, its still used for growth unlike where for bamboo its used to to limit growth.

MrHell228 commented 5 months ago

Makes sense, done

MrHell228 commented 5 months ago

Oh I think I did wrong thing by making new commit instead of using "commit suggestion" button and now I can't press it.