SpongePowered / Sponge

The SpongeAPI implementation targeting vanilla Minecraft and 3rd party platforms.
MIT License
384 stars 211 forks source link

Implement ForwardingViewer & Viewer cleanup #4054

Closed MrHell228 closed 2 months ago

MrHell228 commented 2 months ago

SpongeAPI | Sponge

This PR should be merged after these PRs (so I could resolve here all the merge conflicts with this PR that will likely appear):

Some general points:

MrHell228 commented 2 months ago

Resolved conflicts with sub PRs.

Currently block progress methods work only on server. If we want them to work with client side plugins too (which is one of the goals of this whole PR), we might move blockDescructionId methods from SpongeServer to SpongeEngine. Collisions between client-sent and server-sent ids in theory could be minimized by having different id counters: On server from 0 going down and on client from Integer.MIN_VALUE going up. Does this sound fine?