search

SpongePowered / Sponge

The SpongeAPI implementation targeting vanilla Minecraft and 3rd party platforms.
MIT License
390 stars 211 forks source link

Neoforge update #4114

Closed Outfit8TSB closed 3 months ago

Outfit8TSB commented 3 months ago

https://neoforged.net/news/theproject/ and #4113

in July 12 2023, the MinecraftForge Team, In theory, has disbanded and split into Oldforge and Neoforge. After Disbanding, Neoforge has succeeded the 100% of the MinecraftForge, along with human and material resources.(Unofficial and Spiritual successor of MinecraftForge) Meanwhile the Oldforge has only succeeded it's Name and Leader, MinecraftForge.(legal Successor of MinecraftForge). after the situation, The Neoforge begun the update, removing all Forge Related System. as a result, the forge mods cannot be inserted on Neoforge. this is why the #4113 has been created and this pull request has been made. This is the Part of the SpongePoweredNeoforged Project, Migrating SpongeForge mod to NeoForge. Old Build Numbers: SpongeForge-1.20.6-50.0.22-11.0.1-RC1778 SpongeForge-1.21-51.0.0-12.0.0-RC1234 New Build Numbers: SpongeForge-1.20.6-20.6.119-11.0.1-RC1234 SpongeForge-1.21-21.0.146-12.0.0-RC1234.

This is a Build Number Under the Project. the NeoForge Version 21.0.146 corresponds to Minecraft JE 1.21.

The Pull Request will open as a draft, as we didn't find some minecraft forge code alternative. (the imported minecraft forge class, unable to find the alternative was commented as a // SPONGE-4113[REPLACEMENT NEEDED])

the branch may not compile until it is completely replaced with Neoforge dependencies and class. but the branch can be modified by you guys since i didn't fork this Repository through Organization.(Used Personal fork to create PR)

image.

Zidane commented 3 months ago

With respect, this PR won't be accepted. For the following reasons:

  1. This is a very large change by a community member. This is a community led project, first and foremost, but the people who are official Sponge developers bear that title with an element of obligation that community members don't have. Adding this platform (and replacing the other) incurs new maintenance and time required by us to spend to keep it working or to keep current with changes in the new platform/etc. It would be a disservice to accept this from an individual with no obligation just to see it start stagnating and dying immediately.

  2. As one of the leaders of the project, it is my job to look at the entire landscape when making decisions such as this. We are aware of the situation involving these two projects. We're also aware of a shifting of mod projects between the two. At this time, we have not made an official decision on the forge submodule. This is no sleight against neoforge, this has been the same position we have stated with fabric. We're a very small team with extremely busy lives. Things like this were much easier 7-8 years ago when a lot of us had more time than we knew what to do with.

I hope this clears up this situation. We understand that the community is looking for some decision. We will look to make one as soon as we feel confident we can.

Outfit8TSB commented 3 months ago

ok, thank you.

Outfit8TSB commented 4 weeks ago

[!CAUTION] please be advised: the base issue was closed in favor of SpongeNeo Pull Request. the branch will be deleted immediately.