search

SpongePowered / SpongeAPI

A Minecraft plugin API
http://www.spongepowered.org/
MIT License
1.14k stars 342 forks source link

SpongeEventHandler is inconsistent #174

Closed coelho closed 9 years ago

coelho commented 10 years ago

The annotation org.spongepowered.api.event.SpongeEventHandler is inconsistent with the rest of the API. To fix this, we can either:

1) Change it to org.spongepowered.api.event.EventHandler 2) Change other annotations like org.spongepowered.api.plugin.Plugin to, for example, org.spongepowered.api.plugin.SpongePlugin

Opinions?

AedDev commented 10 years ago

I agree with the first point. But why change from Plugin to SpongePlugin? I see no reason to do that ...

coelho commented 10 years ago

It's just an alternative option that will also accomplish the goal of making things consistent. I'm much more in favor of the first option however.

maxov commented 9 years ago

After some discussion in #175 and IRC, it has been resolved to rename SpongeEventHandler to Subscribe. See 4ed9d791.