search

SpongePowered / SpongeAPI

A Minecraft plugin API
http://www.spongepowered.org/
MIT License
1.14k stars 342 forks source link

Update/1.20.6 #2501

Closed Faithcaio closed 4 months ago

Faithcaio commented 4 months ago

SpongeAPI | Sponge

Yeregorix commented 4 months ago

Instead of having : EngineConnectionState EngineConnectionIntentState EngineConnectionLoginState EngineConnectionConfigurationState EngineConnectionGameState Shouldn't we have : EngineConnectionState EngineConnectionState.Intent EngineConnectionState.Login EngineConnectionState.Configuration EngineConnectionState.Game ? Same for ClientConnectionState and ServerConnectionState.

Also why have EngineConnectionStates (all the constants) ?

aromaa commented 4 months ago

Yes, thanks.

The constants are for the Channels, thats kinda how it was and I just kept the same idea.